feat grpc: ability to provide SSL certificate for GRPC client#1106
Open
DmitriyH wants to merge 1 commit intouserver-framework:developfrom
Open
feat grpc: ability to provide SSL certificate for GRPC client#1106DmitriyH wants to merge 1 commit intouserver-framework:developfrom
DmitriyH wants to merge 1 commit intouserver-framework:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is the only option to provide SSL certificate for GRPC client: from file.
It makes impossible to use a certificate received from an external secret data provider without saving it to disk, while saving private key to disk could potentially lead to a security issue.
It is suggested to declare an abstract component
ugrpc::client::ExternalCredentialsProvider, which is used byugrpc::client::ClientFactoryComponent. Ifugrpc::client::ExternalCredentialsProviderreturns a certificate, then SSL auth is enabled and certificate file path specified for factory config is ignored.A minimal example: