Extend ydb::CoordinationSession semaphore methods#1114
Open
Ilya-Repin wants to merge 1 commit intouserver-framework:developfrom
Open
Extend ydb::CoordinationSession semaphore methods#1114Ilya-Repin wants to merge 1 commit intouserver-framework:developfrom
Ilya-Repin wants to merge 1 commit intouserver-framework:developfrom
Conversation
apolukhin
requested changes
Feb 22, 2026
Member
apolukhin
left a comment
apolukhin
left a comment
There was a problem hiding this comment.
Looks good, please apply a few tweaks:
| @@ -61,13 +61,13 @@ class CoordinationSession final { | |||
| ); | |||
|
|
|||
| /// Create semaphore | |||
Member
There was a problem hiding this comment.
Please, add a description for data parameter
|
|
||
| /// Delete semaphore | ||
| void DeleteSemaphore(std::string_view name); | ||
| void DeleteSemaphore(std::string_view name, bool force = false); |
Member
There was a problem hiding this comment.
Use enum instead of bool. With enums the code becomes more readable:
x.DeleteSemaphore("foo", true);
vs
x.DeleteSemaphore("foo", Mode::kForce);
| void CoordinationSession::DeleteSemaphore(std::string_view name) { | ||
| ExtractResult(session_.DeleteSemaphore(impl::ToString(name)), "DeleteSemaphore"); | ||
| void CoordinationSession::DeleteSemaphore(std::string_view name, bool force) { | ||
| ExtractResult(session_.DeleteSemaphore(impl::ToString(name), force), "DeleteSemaphore"); |
Member
There was a problem hiding this comment.
Please add tests for the both additions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
ydb::CoordinationSessionsemaphore methods (CreateSemaphore,DeleteSemaphore)std::string_view dataargument (default is empty). Allows attaching user-defined metadata to the semaphore upon creation. SDK methodbool forceargument (default isfalse). Enables force deletion of the semaphore. SDK method