Skip to content

fix: restore dialog fade animation after tailwind v4 migration#381

Merged
KMKoushik merged 1 commit intomainfrom
fix/dialog-fade-animation-tailwind-v4
Mar 16, 2026
Merged

fix: restore dialog fade animation after tailwind v4 migration#381
KMKoushik merged 1 commit intomainfrom
fix/dialog-fade-animation-tailwind-v4

Conversation

@KMKoushik
Copy link
Member

@KMKoushik KMKoushik commented Mar 16, 2026

Summary

  • Remove dialog slide-in/slide-out motion classes from the shared DialogContent so modals no longer enter from the side.
  • Keep open/close animation on fade only to match the expected centered modal behavior (e.g. Create Template).
  • Preserve shared dialog API and structure so all existing dialog usages continue to work.

Verification

  • Open the Create Template modal and confirm it fades in/out from center without lateral movement.

Summary by cubic

Restores centered, fade-only dialog animation after the tailwindcss v4 migration. Removes slide/zoom motion classes from shared DialogContent so modals open/close in place without side entry; no API changes.

Written for commit 5478d4b. Summary will update on new commits.

Summary by CodeRabbit

  • Style
    • Simplified Dialog component animations and styling while maintaining all functionality.

@vercel
Copy link

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
unsend-marketing Ready Ready Preview, Comment Mar 16, 2026 11:26am

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8ffbc97-83f0-42c6-ba41-a23a251677d4

📥 Commits

Reviewing files that changed from the base of the PR and between b16eb20 and 5478d4b.

📒 Files selected for processing (1)
  • packages/ui/src/dialog.tsx

Walkthrough

This pull request modifies Dialog UI components to adjust className merging patterns and simplify styling. The changes introduce trailing commas in cn function calls for consistent syntax across components. The DialogContent component's className string is reduced by removing a collection of animation and transition classes, while maintaining core layout and state-driven animations. Other Dialog-related components adopt the same trailing comma pattern in their className handling. The public API and prop types remain unchanged, with observable modifications limited to CSS class composition and the reduced set of animation classes applied at runtime.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing slide-in/slide-out animation classes from DialogContent to restore a fade-only animation after the Tailwind v4 migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@cloudflare-workers-and-pages
Copy link

Deploying usesend with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5478d4b
Status: ✅  Deploy successful!
Preview URL: https://c402b747.usesend.pages.dev
Branch Preview URL: https://fix-dialog-fade-animation-ta.usesend.pages.dev

View logs

@KMKoushik KMKoushik merged commit 741b2b1 into main Mar 16, 2026
6 checks passed
@KMKoushik KMKoushik deleted the fix/dialog-fade-animation-tailwind-v4 branch March 16, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant