fix: restore dialog fade animation after tailwind v4 migration#381
fix: restore dialog fade animation after tailwind v4 migration#381
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request modifies Dialog UI components to adjust className merging patterns and simplify styling. The changes introduce trailing commas in cn function calls for consistent syntax across components. The DialogContent component's className string is reduced by removing a collection of animation and transition classes, while maintaining core layout and state-driven animations. Other Dialog-related components adopt the same trailing comma pattern in their className handling. The public API and prop types remain unchanged, with observable modifications limited to CSS class composition and the reduced set of animation classes applied at runtime. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
Deploying usesend with
|
| Latest commit: |
5478d4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c402b747.usesend.pages.dev |
| Branch Preview URL: | https://fix-dialog-fade-animation-ta.usesend.pages.dev |
Summary
DialogContentso modals no longer enter from the side.Verification
Summary by cubic
Restores centered, fade-only dialog animation after the
tailwindcssv4 migration. Removes slide/zoom motion classes from sharedDialogContentso modals open/close in place without side entry; no API changes.Written for commit 5478d4b. Summary will update on new commits.
Summary by CodeRabbit