Native logical locs #2585
Draft
Native logical locs #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The systematic use of logical locations in TypePal has impact on certain parts of compiler and typechecker. Here are the most relevant points: - All uses of isContainedIn and friends have been reviewed and are usually replaced by calling the Solver version, e.g., s.isContained. - The information organization in the typechcker was ambivalent about the use of a module name or a module location as ky to represent a specific module. This has been fixed: the logical location of a module is used everywhere to identify it, e.g., |rascal+module:///IO|. - A nice side effect of this is that a logical module location also represents the physical module scope, eliminating some extra mappings. - An alias MID (for Module IDentifier) of loc is introduced. The validity of a MID argument of a function is asserted in many places. - As a consequence, many str fields in ModuleStatus have been changed to MID. - Conversions to/from MID/modulename are available. - The best part of all these changes is that the previous, time-consuming, mappings between logical and physical locations have become a thing of the past. TModels now always (either stored in a .tpl file or in memory) use logical locations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6631 6630 -1
=======================================
Files 793 793
Lines 65623 65623
Branches 9828 9828
=======================================
- Hits 30485 30483 -2
- Misses 32782 32786 +4
+ Partials 2356 2354 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit c63510b.
Case in point:
```
data Symbol = label(str lbl, Symbol sym);
void label(value vals...) { }
```
was not handled correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit comments