Custom controller #284
Draft
Custom controller #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Major Features Added ### 1. Enhanced Profile Management System - Added comprehensive sensitivity settings for both physical controllers and virtual (on-screen) controls - Separate dead zone and sensitivity controls for sticks and D-pads - Physical controller settings: stick dead zone, stick sensitivity, dpad dead zone - Virtual control settings: stick dead zone, stick sensitivity, dpad dead zone - New touchpad gesture settings (tap-to-click, two-finger right-click) - Mouse/touch behavior modes (touchscreen mode, disable touchpad mouse) - Game-specific profile locking system (profiles can be locked to specific containers/games) ### 2. New UI Dialogs (15 new Compose-based dialogs) - UnifiedProfileEditorDialog: Complete profile editor with live preview and undo support - UnifiedProfileCreationDialog: Unified creation flow for all profile types - InGameProfileManagerDialog: In-game profile switching/creation - ProfilePickerDialog, CloneProfileDialog, CreateBlankProfileDialog, CreateFromTemplateDialog - ElementEditorDialog, ControllerBindingDialog: Control element editing - ImportProfileDialog: File picker for importing .icp profiles - ProfileSelectionCard: Settings card for profile management - Sensitivity, gesture, and mouse behavior settings components ### 3. Critical Bug Fixes - **Fixed sensitivity settings not being applied**: Physical stick sensitivity, virtual stick sensitivity, and dead zones are now properly applied during gameplay - Added sensitivity parameter to ExternalController.processJoystickInput() - Updated WinHandler to retrieve and pass sensitivity from profile - Fixed InputControlsView to use profile settings instead of hardcoded constants - **Fixed physical controller editor crash**: Corrected Orientation.fromInt(0) returning empty EnumSet - **Fixed undo tracking**: Undo now remembers moves across drag sessions ### 4. Profile Name Validation - Added validateProfileName() with comprehensive checks for filesystem-unsafe characters - Added sanitizeProfileName() for auto-generated names - Updated all profile creation dialogs to use validation - Prevents special characters: / \ : * ? " < > | - Enforces max length (100 characters) and other safety checks ### 5. Export/Import Functionality - Added export button to UnifiedProfileEditorDialog toolbar - Created ImportProfileDialog with file picker functionality use your downloads folder - Added import/export to settings ProfileSelectionCard dropdown - Exports to Downloads/Winlator/profiles/ with sanitized filenames - Full support for sharing profiles between devices ### 6. Enhanced Reset to Default Dialog - Added "All Buttons" checkbox to reset dialog - Users can selectively reset: Left Stick, Right Stick, D-Pad, and All Buttons - Preserves custom bindings for unselected controls ### 7. New Default Profiles - Added controls-4.icp through controls-7.icp templates - Updated existing profiles (controls-1, 2, 3) with new sensitivity fields
## Profile Editor Enhancements: - Added redo functionality with undo/redo stack management - Fixed undo/redo tracking to prevent phantom snapshots during operations - Improved system UI hiding for true immersive fullscreen mode - Clear undo/redo stacks on save, cancel, and dismiss to prevent confusion - Better element movement detection and tracking ## Profile Creation UX: - Auto-strip "Template" word from template names when creating profiles - Show profile ID and element count in profile cards - Enhanced profile card layout with better visual hierarchy - Improved locked/global profile status display ## File Browser Improvements: - Added permission checks for directory access - Handle read permission errors gracefully with toast messages - Filter out inaccessible directories - Clear search query when navigating into folders 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add ControllerBindingPresets.kt with quick preset configurations for controller mappings - Add PhysicalControllerConfigSection.kt for comprehensive controller binding management - Improve ElementEditorDialog with debounced text updates to reduce excessive redraws - Enhance UnifiedProfileEditorDialog with profile rename functionality and memory leak fixes - Update ExternalController and InputControlsView for improved controller handling
# Conflicts: # app/src/main/java/app/gamenative/ui/component/dialog/ContainerConfigDialog.kt # app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt # app/src/main/java/com/winlator/container/ContainerData.kt
# Conflicts: # app/src/main/java/app/gamenative/ui/screen/library/appscreen/BaseAppScreen.kt # app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt # app/src/main/java/com/winlator/container/ContainerData.kt
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.