Added the danish translations v2 #313
Conversation
WalkthroughThis pull request adds comprehensive Danish translations to the string resources file, covering Steam features, Custom Games functionality, environment variable help texts, app filtering, and various UI elements across the application. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/src/main/res/values-da/strings.xml(23 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Request build check
app/src/main/res/values-da/strings.xml
[error] 19-19: Execution failed for task ':app:mergeDebugResources'. The entity name must immediately follow the '&' in the entity reference.
🔇 Additional comments (1)
app/src/main/res/values-da/strings.xml (1)
1-785: Comprehensive Danish translations added successfully.The translation coverage is extensive and well-organized across all major app sections: Steam integration, Custom Games, Container configuration, Settings, Driver Manager, Wine/Proton Manager, and more. Once the XML entity escaping issues are resolved, this contribution will significantly improve Danish language support.
| <string name="steam_install_not_enough_space">Appen der installeres har brug for %1$s plads, men der er kun %2$s tilbage på denne enhed</string> | ||
| <string name="steam_cancel_download_message">Er du sikker på, at du vil annullere download af appen?</string> | ||
| <string name="steam_delete_download_message">Slet alle downloadede data for dette spil?</string> | ||
| <string name="steam_imagefs_download_install_title">Download & installér ImageFS</string> |
There was a problem hiding this comment.
CRITICAL: Fix unescaped ampersand breaking the build.
The & character in "Download & installér ImageFS" must be escaped as & in XML. This is causing the build failure: The entity name must immediately follow the '&' in the entity reference.
- <string name="steam_imagefs_download_install_title">Download & installér ImageFS</string>
+ <string name="steam_imagefs_download_install_title">Download & installér ImageFS</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="steam_imagefs_download_install_title">Download & installér ImageFS</string> | |
| <string name="steam_imagefs_download_install_title">Download & installér ImageFS</string> |
🧰 Tools
🪛 GitHub Actions: Pull Request build check
[error] 19-19: Execution failed for task ':app:mergeDebugResources'. The entity name must immediately follow the '&' in the entity reference.
🤖 Prompt for AI Agents
In app/src/main/res/values-da/strings.xml around line 19, the string contains an
unescaped ampersand ("Download & installér ImageFS") which breaks XML parsing;
replace the raw '&' with the XML entity '&' so the value becomes "Download
& installér ImageFS" and re-run the build to confirm the parsing error is
resolved.
| <!-- Libraries Dialog --> | ||
| <string name="libraries_title">Anvendte biblioteker</string> | ||
| <string name="libraries_message">Pluvia - github.com/oxters168/Pluvia\nJavaSteam - github.com/Longi94/JavaSteam\nWinlator & Vortek - github.com/brunodev85/winlator\nWinlator Cmod - github.com/coffincolors/winlator\nWrapper - https://github.com/leegao/bionic-vulkan-wrapper & https://github.com/pipetto-crypto/\nUbuntu RootFs - releases.ubuntu.com/focal</string> | ||
| <string name="libraries_message">Pluvia - github.com/oxters168/Pluvia\nJavaSteam - github.com/Longi94/JavaSteam\nWinlator & Vortek - github.com/brunodev85/winlator\nWinlator Cmod - github.com/coffincolors/winlator\nWrapper - https://github.com/leegao/bionic-vulkan-wrapper & https://github.com/pipetto-crypto/\nUbuntu RootFs - releases.ubuntu.com/focal</string> |
There was a problem hiding this comment.
Fix additional unescaped ampersand at line 630.
The & in "Winlator & Vortek" must also be escaped as & to prevent a similar build failure.
- <string name="libraries_message">Pluvia - github.com/oxters168/Pluvia\nJavaSteam - github.com/Longi94/JavaSteam\nWinlator & Vortek - github.com/brunodev85/winlator\n...
+ <string name="libraries_message">Pluvia - github.com/oxters168/Pluvia\nJavaSteam - github.com/Longi94/JavaSteam\nWinlator & Vortek - github.com/brunodev85/winlator\n...(Apply the same escape to the full string content at line 630.)
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In app/src/main/res/values-da/strings.xml around line 630, the string contains
an unescaped ampersand ("Winlator & Vortek") which will break XML parsing;
update the entire string value to replace all literal '&' characters with
'&' (including the "Winlator & Vortek" occurrence and any other unescaped
ampersands) so the XML is well-formed and the build succeeds.
|
Hey @Maaggel . Do we still need this PR? Just wanting to check if you wanna update this or close the PR |
2 participants
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.