Dimension for project-specific role

[hmacr]

Closes SER-541

Summary by CodeRabbit

• Tests

  • Expanded coverage for team roles, multi-part project dimensions, verified/unverified variants, and label role formats; added validation cases for longer dimension values.

• Refactor

  • Consolidated role validation into contextual validators for unified identifier and dimension checks.

• Bug Fixes

  • Increased allowed dimension length to 81 characters and updated validation messages accordingly.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaces inline Key/Label checks in the Roles validator with contextual validators: identifierValidator (uses Label when ROLE_LABEL otherwise Key), and dimensionValidator (Key with maxLength 81). Unifies identifier/dimension validation flows and updates tests to cover team roles with project-scoped dimensions and the longer dimension limit.

Changes

Cohort / File(s)	Summary
Validator refactor src/Database/Validator/Roles.php	Replaced per-branch Key/Label checks with contextual identifierValidator (Label for ROLE_LABEL, otherwise Key) and dimensionValidator (Key, maxLength 81); routed validation and error messages through these validators and removed direct $key/$label conditionals.
Role parsing/stringification tests tests/unit/RoleTest.php	Added parsing and toString assertions for team roles with project-scoped dimensions (team:123/project-456-owner, team:123/project-456) and corresponding Role constructions.
Roles validator tests tests/unit/Validator/RolesTest.php	Added PHPUnit tests covering DIMENSION_VERIFIED, DIMENSION_UNVERIFIED, team roles with custom IDs and project-scoped dimensions, and a label role; imported ID helper.
Permissions validator tests (length limit update) tests/unit/Validator/PermissionsTest.php	Extended dimension value max length from 36 to 81 in tests and added boundary cases (e.g., 81 valid, 82 rejected); preserved identifier length expectations and added a 37-char invalid identifier test.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I nudged checks into neat little bins,
identifier and dimension with grins.
Teams can hop farther, projects in sight,
Tests give a thump — everything's right.
🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Dimension for project-specific role' directly describes the main change: adding dimension support for project-specific roles, which is confirmed by the raw summary showing dimension validation updates and new test cases for project-based role dimensions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hmacr]

CodeQL and Pool tests seem to be failing in other recent PRs as well.