Simplify UpdateDetails to auto-renew

[ChiragAgg5k]

Summary

• simplify UpdateDetails to autoRenew only
• move adapter-specific formatting into adapters
• update tests and README example
• fix OpenSRS auto-renew modify payload (use expire_action)

Testing

• not run (not requested)

Summary by CodeRabbit

• New Features

  • Added public domain methods (updateDomain, checkTransferStatus) and a unified UpdateDetails with an autoRenew field.

• Bug Fixes

  • Simplified update validation to require auto-renew setting and removed extraneous contact-based validation.

• Documentation

  • Updated API docs and README with usage examples showing how to update domain auto-renew.

• Tests

  • Updated tests to use the simplified UpdateDetails signature and removed obsolete contact-validation tests.

[coderabbitai]

Warning

Rate limit exceeded

@ChiragAgg5k has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

The PR replaces the abstract adapter-specific UpdateDetails pattern with a single final UpdateDetails class exposing a nullable autoRenew property. Adapter-specific UpdateDetails classes (Mock, NameCom, OpenSRS) were removed and their adapters were updated to build payloads directly from autoRenew. Contact-handling and related validation in the Mock adapter were removed. Tests and test helpers were updated to use the new UpdateDetails constructor. README and public API docs were updated with new usage examples and method signatures.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: simplifying UpdateDetails to focus on auto-renew only, which is confirmed by the removal of adapter-specific UpdateDetails classes and the conversion of the base UpdateDetails to a concrete class with a single autoRenew property.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/simplify-update-details

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/Domains/Registrar/Adapter/OpenSRS.php`:
- Around line 595-602: The MODIFY payload currently builds $attributes with
'data' => 'auto_renew' and no let_expire, causing OpenSRS to reject the command;
update the payload in OpenSRS.php where $attributes is constructed (using
$details->autoRenew) to set 'data' => 'expire_action' and include a 'let_expire'
key (set to 1 when letting expire, 0 otherwise) alongside 'auto_renew' so the
MODIFY action complies with OpenSRS requirements.

🧹 Nitpick comments (2)

tests/Registrar/NameComTest.php (1)

85-88: All three test files have identical getUpdateDetails implementations.

Since MockTest, NameComTest, and OpenSRSTest all return new UpdateDetails($autoRenew) with the same logic, this could be a concrete method in Base.php rather than an abstract override in each subclass.

tests/Registrar/Base.php (1)

266-276: Consider adding test coverage for autoRenew = false and autoRenew = null.

The test only exercises getUpdateDetails(true). Since UpdateDetails accepts ?bool, it may be worth testing the false and null cases to ensure all adapters handle them correctly — especially null, which signals "no change."

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Domains/Registrar/Adapter/OpenSRS.php (1)

626-630: ⚠️ Potential issue | 🔴 Critical

Guard $elements[0] against empty array at line 630.

The XPath query drills into a deeply nested response path (attributes/details/{domain}/is_success). If the OpenSRS API response for the MODIFY expire_action action doesn't include this exact nesting structure, the xpath() call returns an empty array, triggering "Undefined array key 0".

Other methods in this file (e.g., updateNameservers at line 122, cancelPurchase at line 263) use a simpler top-level is_success check. Consider whether this deeply nested path is correct for the MODIFY action, or fall back to the top-level check:

Proposed fix

         $result = $this->send($message);
         $result = $this->sanitizeResponse($result);
         $elements = $result->xpath($xpath);
 
-        return (string) $elements[0] === '1';
+        if (empty($elements)) {
+            $elements = $result->xpath('//body/data_block/dt_assoc/item[`@key`="is_success"]');
+        }
+
+        return !empty($elements) && (string) $elements[0] === '1';