feat(cardano): simplify Asset type
#182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since currently both of the variants of
quantitycan store negative values, there is no point of having them both if they serve the same purpose.There is a problem though:
BigIntcan store negative values, which do not make sense in case of assets in transaction outputs. One way to approach this would be to keep sum typequantitybut use two different types:BigIntand some new type representing only positive values for example:The question is if the introduced complexity justifies the gain in type safety.