Skip to content

Comments

fix: Fix pre-commit errors#34

Merged
lsetiawan merged 4 commits intomainfrom
fix_errs
Apr 21, 2025
Merged

fix: Fix pre-commit errors#34
lsetiawan merged 4 commits intomainfrom
fix_errs

Conversation

@lsetiawan
Copy link
Member

@lsetiawan lsetiawan commented Apr 21, 2025

This pull request includes updates to dependencies, configuration files, and a notebook script to improve compatibility, maintainability, and code quality. Below is a summary of the most important changes grouped by theme:

Dependency Updates:

  • Updated the pre-commit hooks to use newer versions of tools such as prettier, ruff, mypy, codespell, validate-pyproject, check-jsonschema, and sp-repo-review for improved functionality and bug fixes. [1] [2] [3]

CI Workflow Improvements:

  • Updated the codecov-action in .github/workflows/ci.yml to version v5.3.1 for better coverage reporting.
  • Adjusted the runs-on syntax in .github/workflows/codeql.yml for clarity and maintainability.

Notebook Script Enhancements:

  • Replaced np.random.seed with np.random.default_rng for better random number generation practices in docs/notebooks.ipynb.
  • Added matplotlib.lines.Line2D import at the beginning of the notebook for better code organization.

Configuration File Adjustments:

  • Standardized the logging level in pyproject.toml by changing log_cli_level to uppercase INFO.
  • Removed the src key from the ruff configuration in pyproject.toml to simplify the setup.

Minor Syntax Changes:

  • Standardized the cron schedule format in .github/workflows/codeql.yml by using double quotes.This pull request includes various updates across multiple files to improve code consistency, address deprecations, and enhance maintainability. Key changes include updates to workflow configuration, dependency adjustments, and code improvements in documentation and source files.

Workflow Configuration Updates:

  • .github/workflows/codeql.yml: Reformatted the runs-on property for better readability and replaced single quotes with double quotes in the schedule cron expression for consistency. [1] [2]

Dependency and Configuration Adjustments:

  • .pre-commit-config.yaml: Updated the Prettier hook to use a different repository (rbubley/mirrors-prettier) and downgraded the version to v3.5.3 for compatibility.
  • pyproject.toml: Standardized the logging level to uppercase (INFO) and removed the src directory from the Ruff linter configuration's src property. [1] [2]

Documentation Code Improvements:

  • docs/notebooks.ipynb: Replaced np.random.seed with np.random.default_rng for better random number generation practices and optimized imports by moving Line2D to the top of the file. [1] [2]

Related PRs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2f3a1c3) to head (468e9bc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            6         6           
=========================================
  Hits             6         6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lsetiawan lsetiawan merged commit 1b1e2fc into main Apr 21, 2025
14 checks passed
@lsetiawan lsetiawan deleted the fix_errs branch April 21, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant