Modify the problem that the group name cannot be obtained#114
Modify the problem that the group name cannot be obtained#114chuanyichuan wants to merge 1 commit intouwolfer:masterfrom
Conversation
|
Can you please post some details about the bug? Does it lead in an exception? Or does it just not work as expected? |
Hi, it's a great honor to receive your reply. It is not a bug, just dose not work as expected. When I get the list of group, id and name are the same value, like that: The key of map is my group's name, but the instance's name is null.It not work as expected, and I don't think it is reasonable. So I modify it, and I would like to bring your attention to review it. the result is: Thank you. |
| e.getValue().name = e.getKey(); | ||
| result.add(e.getValue()); | ||
| } | ||
| List<GroupInfo> result = new ArrayList<>(map.values()); |
There was a problem hiding this comment.
Files in the com.google package should not be touched as these are copied over from official Gerrit source from time to time. Does your "fix" also work without this change? Or do you see any alternatives to fix this issue?
2 participants
In use, I found that the name of the group could not be obtained. After checking the source code, I found that in the class Groups#ListRequest, id was used to assign a value to name