fix: Handle translation requests when session is expired #23239
Conversation
|
What is the session used for in the handler? |
|
Apparently it is not used at all, but there is no way to have a request handler that does not care about the session? |
|
Exactly. Request Handlers are invoked after the attempt to create/get a Vaadin session is already done. |
| @Override | ||
| public boolean synchronizedHandleRequest(VaadinSession session, | ||
| VaadinRequest request, VaadinResponse response) throws IOException { | ||
| handleTranslationRequest(session.getService(), request, response); |
There was a problem hiding this comment.
This could be request.getService() instead to be clear that the session is not needed
There was a problem hiding this comment.
Good point. I'll fix that.
| @Override | ||
| public boolean handleSessionExpired(VaadinRequest request, | ||
| VaadinResponse response) throws IOException { | ||
| if (!canHandleRequest(request)) { |
There was a problem hiding this comment.
nit: Somehow this looks inverted to me when it could be "if we can handle, handle it, otherwise don't"
Implement SessionExpiredHandler in TranslationFileRequestHandler to serve translations even when no active session exists. This allows i18n requests to work correctly with stateless authentication. Fixes #23238
mcollovati
force-pushed
the
issues/23238-TranslationFileRequestHandler_sessionExpired
branch
from
dedacc9 to
8c1382e
Compare
|
Implement SessionExpiredHandler in TranslationFileRequestHandler to serve translations even when no active session exists. This allows i18n requests to work correctly with stateless authentication.
Fixes #23238