Added new options when end can't be reached#4
Open
carloshenrq wants to merge 1 commit intovalantonini:masterfrom
Open
Added new options when end can't be reached#4carloshenrq wants to merge 1 commit intovalantonini:masterfrom
carloshenrq wants to merge 1 commit intovalantonini:masterfrom
Conversation
… can't be reached.
a7244b4 to
d218e7f
Compare
Owner
|
Thanks @carloshenrq, this is a neat idea. I'll have a look over it a soon but at first glance, it looks like it will need some unit tests before I can merge it into master. I'm happy to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @valantonini, I must thank you for this pretty A* implementation.
My pull request added a new option when the final node can't be reached. If this happens, a recursive call is made and the path returned is with the first closest node from the final node.
I don't know if this is the best and most optimized way to do it but works like a charm for me.
In this situation, the code returns 0 nodes, the unit can't walk from (1,4) to (4,1).
With this pull request this should happen:
(1,4) -> (1,3) -> (2,2) -> (3,2) -> (4,2)