Improve monad transformers support#198
Open
madidier wants to merge 7 commits intovalderman:masterfrom
Open
Conversation
…, ie. stuff built on ExceptT
exaexa
approved these changes
Oct 25, 2025
Collaborator
exaexa
left a comment
There was a problem hiding this comment.
Note for self: we should bump changelog once this is in.
@madidier I think this can go in as is (we'll wait for @valderman for ack). Anyway, it's a year or so, so if there's any new update to add please let us know (but there doesn't seem to be much news in mtl since then so I don't expect much :) ). Thanks!
Author
|
Hi @exaexa. Thanks for having a look at this PR. To be honest, I haven't touched this project in over a year, so I have no update to share. Should be fine as long as the code still compiles and the tests pass :) |
Collaborator
OK thanks for confirm, that indeed seems to be the case :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following limitations:
SeldaT, ie.SeldaT b (StateT s IO)did not have aMonadState sinstance,SeldaTcould only be used as outermost element in the transformer stack, ie.StateT s (SeldaT b IO)did not have aMonadSeldainstance,onExceptionmade it unsafe to use a base monad that uses any form of short-circuiting that is not an exception, ie. ExceptT.Fixing that last point requires using
generalBracketintroduced inexceptions-0.9, so I had to bump the dependency requirement. I am not sure how this impacts the range of GHC versions that can be supported.Supporting
ExceptT/MonadErroris rather important for applications based on servant.