WIP: Properly parameterize managed cluster names#9
Merged
mhjacks merged 1 commit intovalidatedpatterns:mainfrom Feb 23, 2026
Merged
WIP: Properly parameterize managed cluster names#9mhjacks merged 1 commit intovalidatedpatterns:mainfrom
mhjacks merged 1 commit intovalidatedpatterns:mainfrom
Conversation
mhjacks
changed the title
Contributor
Author
|
While here I also want to test 4.20 and the productized ESO, so the core stuff is fixed but it's WIP because of those two things. |
nadavleva
reviewed
Feb 16, 2026
nadavleva
left a comment
nadavleva
left a comment
There was a problem hiding this comment.
Why not generate random seed to cluster names to avoid naming conflicts
Revert "Test name change" This reverts commit b451a92. Parameterize names Test name parameterization Unify naming strategy Factor out cluster names Upgrade to ACM 2.14 Standardize on RDR structure Preserve the whole structure to prevent render failures Parameterize primary/secondary cluster for edge-gitops-vms Fixups for gitops-vms deployments Update Changes.md Commit cursor swing at simplification Parameterize preferred cluster Parameterize other DRPC aspects Consolidate DRPC parameters Fix template render error Fix another template render failure Sanitize install_config Fixup template again Update method to retrieve CAs Update method to retrieve CAs Update method for editing CAs Update logging and be more careful in python Try this approach - watch S3ProfileNames though Use cluster names Refactor validation to ensure there are just two profiles as long as the CA material is present Rebase with main in mind Try a different approach to validation Change grep technique Fix validation Ensure cluster labels are set Change label to clusterset for ACM membership Ensure clusterGroup is set Enhance merge logic for install config Enhance merge logic further Piece out overrides further to ensure machine types and regions are properly handled Restore default cluster naming Continue refining override logic Correct spelling for secondary Remove RegionalDR from values-hub and move sharedValueFiles to extraValueFiles for apps that matter Add additional validation scripts Create script and doc for updating the JSON files Fix lint error in markdown Update cluster validation Revert some bad logic introduced for bad reasons (ODF was not deploying and I thought the script was wrong) Simplify certificate extraction to only use yq Avoid overly large shell command Reformat README to silence super-linter Specify argocd server to avoid error Do not exit successfully if both clusters are not deploying Force sync via gitops-vms namespace Rationalize cron and non-cron argo monitors, force sync a namespace Correct namespace Update changelog
mhjacks
force-pushed
the
test_name_change
branch
from
42b1348 to
ed1312c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.