Merged
Conversation
kylebrowning
approved these changes
Oct 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 42.47% 43.05% +0.57%
==========================================
Files 13 13
Lines 871 871
==========================================
+ Hits 370 375 +5
+ Misses 501 496 -5
🚀 New features to boost your workflow:
|
…others aren't honoring it
MahdiBM
reviewed
Oct 24, 2025
| - postgres:13 | ||
| - postgres:18 | ||
| - postgres:16 | ||
| - postgres:14 |
Contributor
There was a problem hiding this comment.
We should keep pg 13 I'd say, as long as Postgres themselves are supporting it.
Member
Author
There was a problem hiding this comment.
There were no protocol changes between 13 and 14, so I see no point in making the test matrix even larger; it doesn't actually tell you anything that the test for 14 doesn't.
Contributor
There was a problem hiding this comment.
I wasnt thinking about a larger matrix. Mostly just replacing 14 with 13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 2.15.0
Also update CI and convert the tests to SwiftTesting.