Adding method that returns PSR-7 response object#15
Closed
fontebasso wants to merge 2 commits intovarsitynewsnetwork:masterfrom
Closed
Adding method that returns PSR-7 response object#15fontebasso wants to merge 2 commits intovarsitynewsnetwork:masterfrom
fontebasso wants to merge 2 commits intovarsitynewsnetwork:masterfrom
Conversation
|
Looks very good, thank you! :-) |
Member
|
Thanks @fontebasso! There's a lot of duplicated code here, and I'm not sure it's a requirement that the response type be |
|
I've taken a different route to solving the same issue in my PR. I needed this feature for pagination purposes, but I wanted to have the original request available as well for generating next/previous links. Anyway, I think this would be a nice feature to have either way! 👍 |
|
For review: #26 |
Author
|
Closing this PR as it’s been open for over 7 years and I no longer believe it’s relevant to the project. Thank you for the opportunity to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close # 13
Adding
getResponsemethod that returns a response object that implementsResponseInterfacefrom PSR-7I have not modified the
getmethod of AbstractWpEndpoint at: https://github.com/varsitynewsnetwork/wordpress-rest-api-client/blob/master/src/Endpoint/AbstractWpEndpoint.php#L46-L49 with the intention of preserving the compatibility as described by @te-online.