Skip to content

[HOTFIX] Chrome displayed a scroll on vault card secrets#182

Merged
vbetsch merged 1 commit intodevelopfrom
hotfix/ui/overflow-chrome
Sep 17, 2025
Merged

[HOTFIX] Chrome displayed a scroll on vault card secrets#182
vbetsch merged 1 commit intodevelopfrom
hotfix/ui/overflow-chrome

Conversation

@vbetsch
Copy link
Owner

@vbetsch vbetsch commented Sep 17, 2025

No description provided.

@vbetsch vbetsch requested a review from Copilot September 17, 2025 14:57
@vbetsch vbetsch self-assigned this Sep 17, 2025
@vbetsch vbetsch added bug Something isn't working ui About templating and styling labels Sep 17, 2025
@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
locklite Ready Ready Preview Comment Sep 17, 2025 2:59pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a UI issue where Chrome was displaying unwanted scroll bars on vault card secrets by changing the overflow behavior from 'scroll' to 'auto'.

  • Changed overflow property from 'scroll' to 'auto' in VaultCardContentLine component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +29 to 30
overflow={'auto'}
textOverflow={'ellipsis'}
Copy link

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both overflow: 'auto' and textOverflow: 'ellipsis' together may not work as expected. The textOverflow: 'ellipsis' property requires overflow: 'hidden' to function properly. Consider using overflow: 'hidden' instead of 'auto' if the intent is to show ellipsis for overflowing text.

Suggested change
overflow={'auto'}
textOverflow={'ellipsis'}
overflow={'hidden'}
textOverflow={'ellipsis'}
whiteSpace={'nowrap'}

Copilot uses AI. Check for mistakes.
@vbetsch vbetsch changed the title Chrome displayed a scroll on vault card secrets [HOTFIX] Chrome displayed a scroll on vault card secrets Sep 17, 2025
@vbetsch vbetsch merged commit d4d926e into develop Sep 17, 2025
6 checks passed
vbetsch added a commit that referenced this pull request Sep 17, 2025
 [HOTFIX] Chrome displayed a scroll on vault card secrets #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui About templating and styling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants