Look for libcrypto bundled with Windows python releases; provide option to use something else#24
Open
zougloub wants to merge 1 commit intovbwagner:masterfrom
Open
Look for libcrypto bundled with Windows python releases; provide option to use something else#24zougloub wants to merge 1 commit intovbwagner:masterfrom
zougloub wants to merge 1 commit intovbwagner:masterfrom
Conversation
Owner
|
Thanks, good idea. It seems that in the time when I've wrote this code Windows python didn't bundle version of OpenSSL library, which is new enough for my purposes. If library in recent version of python does work. it surely should be included into But it looks like on windows we are looking in the default locations only for libeay32.dll, not for libcrypto.dll. If python does ship libcrypto.dll, probably it means that there can be other windows builds of OpenSSL which use libcrypto.dll and libssl.dll instead of libeay32.dll and ssleay32.dll. May be it is better to append python installation dir to os.environ['PATH'] and search for both libeay32 and libcrypto dlls using find_library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adding:
New code path tested with python 3.10b3 on Windows.