Skip to content

Snapshot Theme Toggling #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brody2002 merged 7 commits into from
Jul 2, 2025
Merged

Snapshot Theme Toggling #38

brody2002 merged 7 commits into from
Jul 2, 2025

Conversation

@brody2002
Copy link
Collaborator

@brody2002 brody2002 commented Jun 30, 2025

Changes:

  • FlowStack now appropriately captures theme changes.
  • FlowStack's PathContext Object now stores a dictionary of two snapshots for .dark and .light .This is because taking a snapshot while in the destination View causes a poor visual transition and captures the destination rather than the source.
  • FlowStack's Equatable function no longer compares it's context. This is due to the fact that on a themeChange, the previous PathContext's currentSnapshot is being changed to that of its other theme.

@brody2002 brody2002 requested a review from zac June 30, 2025 17:19
@brody2002 brody2002 merged commit e9c3462 into main Jul 2, 2025
2 checks passed
brody2002 added a commit that referenced this pull request Jul 14, 2025
@brody2002
Revert "Snapshot Theme Toggling (#38)"
4ec527f 
This reverts commit e9c3462.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zac zac zac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brody2002 @zac