feat: add PSA profile support to cocli for issue #42 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukuna0007Abhi
changed the title
- Add PSA profile CoRIM template with URI tag:arm.com,2025:psa#1.0.0 - Create comprehensive PSA CoMID examples: * Reference values for PSA software components * Attestation verification keys (IAK) * Certification claims for PSA Certified SAC * Software relations for updates/patches - Update corim submit command to support new PSA profile media type - Add PSA profile examples to corim create help text - Include comprehensive test coverage for new PSA profile functionality - Add documentation and usage examples for PSA profile workflow This makes the PSA profile functionality from veraison/corim#215 available through the command line interface as requested. Resolves veraison#42 Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
Sukuna0007Abhi
force-pushed
the
feature/issue-41
branch
from
fabfa7b to
af8124f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements CLI support for the new PSA profile functionality from veraison/corim#215, making PSA endorsements available through the command line interface.
Changes Made
New PSA Profile Template
data/corim/templates/corim-psa.jsonwith the new PSA profile URItag:arm.com,2025:psa#1.0.0PSA CoMID Examples
data/comid/psa/psa-reference-values.json- PSA software component reference valuesdata/comid/psa/psa-attestation-key.json- PSA Initial Attestation Key verification keysdata/comid/psa/psa-certification-claims.json- PSA Certified Security Assurance Certificate claimsdata/comid/psa/psa-software-relations.json- PSA software update and patch relationshipsCLI Command Updates
corim submithelp text to include both legacy and new PSA profile media typescorim createcommand helpTest Coverage
Usage Examples
Create PSA CoRIM
Submit PSA CoRIM
cocli corim submit
--corim-file=psa-corim.cbor
--api-server="https://veraison.example/endorsement-provisioning/v1/submit"
--media-type="application/corim-unsigned+cbor; profile=tag:arm.com,2025:psa#1.0.0"
Compliance
Follows draft-fdb-rats-psa-endorsements-08 specification
Compatible with PSA profile implementation from corim#215
Maintains existing CLI patterns and conventions
Testing
All tests pass including new PSA profile test case
Manual testing confirms PSA CoRIM creation and submission workflows work correctly
Resolves #42
Ready for Review sir @thomas-fossati sir @setrofim @deeglaze ma'am