fix: Revert "fix: resolve cjs deps as cjs instead of esm (#362)"#365
Merged
fix: Revert "fix: resolve cjs deps as cjs instead of esm (#362)"#365
Conversation
This reverts commit 1eba4d5.
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
styfle
approved these changes
Oct 2, 2023
Member
|
@cb1kenobi Can you update the PR description to explain why its reverted? |
styfle
changed the title
|
🎉 This PR is included in version 0.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1eba4d5.
The fix in the original PR did solve the problem of tracing a dependency being loaded from an ESM file via
require(), but also caused a regression where a simple.mjsfile with ESM imports was failing. I have a test (#364) for that.