[PHP-128716] Bake cortex config file & install cortex CLI#328
[PHP-128716] Bake cortex config file & install cortex CLI#328
Conversation
| apt-get update && \ | ||
| apt-get install -y gh=2.86.0 && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
| ARG GH_CLI_VERSION=2.86.0 |
| @@ -0,0 +1,85 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
we should try to avoid sharing internal verily1 information with the outside world. This repository is public.
@yuhuyoyo I think we discussed this a while ago. To doublecheck- I think the ideal plan is to migrate this repo to verily1 and copybara it externally. Our team may start needing this soon, as we make the setup more verily1 specific.
A potential solution is to fork the necessary scripts from this repo, into verily1 inside mlplatform, and merge back to with workbench later on?
There was a problem hiding this comment.
agree this script can't be here. even if we copybara, the copybara pipeline will be set up to reject verily1 specific keyword such as cortex.
we can put this script in verily1 mlplatform tools and just clone the repo in the app and then run it from inside the app? a little more involved for the user.
| @@ -0,0 +1,86 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I think we have 2 options:
- fork the relevant files in this repo to verily1/mlplatform/.... serve our cloud app from there ... keep the naming as is.
- rename variables in this file so they don't mention cortex or verily1 internals.
I'm leaning towards 1 if that gives a better UX. Although it will mean more duplication and maintenance burden for A&A in the interim.
@yuhuyoyo WDYT?
@tuckduck as an aside, did we consider getting this data using the wb cli tool? (may be more resilient to future VWB changes, in case the VWB CLI tool exposes this information.
3 participants
Outcome of PHP design-review for Hermetic Cortex changes was to move environment specific config into devcontainer setup, and have cortex just grab it from a baked in config file. This PR adds the creation of cortex.yaml and installing cortex-cli to the vscode-docker custom cloud app
PHP-128716