Merged
Conversation
1 task
ibc
commented
Oct 26, 2025
Comment on lines
-497
to
+498
| rid: data.rid() ?? undefined, | ||
| rid: data.rid() || undefined, |
Member
Author
There was a problem hiding this comment.
This is because if rid is empty string we want it to become undefined. Same in all similar changes below.
ibc
commented
Oct 26, 2025
Comment on lines
-109
to
-112
| if (this->mid.empty()) | ||
| { | ||
| MS_THROW_TYPE_ERROR("empty mid"); | ||
| } |
Member
Author
There was a problem hiding this comment.
This was a terrible idea. In the copy constructor we may perfectly copy from a RtpParameters instance whose mid was not set and hence it has empty string as value, and this block of code would literally throw. There is no reason for this check here. If mid is not set then it is an empty string in RtpParameters, but then, when moving it to Node/Rust, we avoid serializing it so we are good. This check was buggy and totally unneeded.
ibc
commented
Oct 26, 2025
jmillan
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
RtpParameters: addmsidoptional field mediasoup-client#352msidoptional string field toRtpParameters.Bonus tracks
cargo buildfails in latest macOS due to removed macro_LIBCPP_ENABLE_ASSERTIONS#1633TODO