Open
Conversation
Contributor
Author
|
retest |
chriskirby1
force-pushed
the
clk/srch-fixes
branch
2 times, most recently
from
2b85759 to
4a1cdbd
Compare
Contributor
Author
|
retest |
1 similar comment
Contributor
Author
|
retest |
chriskirby1
force-pushed
the
clk/srch-fixes
branch
from
4a1cdbd to
ba3e622
Compare
Contributor
Author
|
retest |
2 similar comments
Contributor
Author
|
retest |
Contributor
Author
|
retest |
chriskirby1
force-pushed
the
clk/srch-fixes
branch
from
ba3e622 to
7081c95
Compare
chriskirby1
force-pushed
the
clk/srch-fixes
branch
from
7081c95 to
88379e2
Compare
Contributor
Author
|
retest |
Because the srch triggers are inherently async to the test, we can't be sure they won't fire prematurely just because a compact worker started running at an inconvenient time. Make the trigger arming silent to avoid spurious test failures. Move the trigger arming closer to the point of interest to increase the chances that we're actually testing what we want. Signed-off-by: Chris Kirby <ckirby@versity.com>
Print the first and last entries, the entry_nr and entry_bytes. Signed-off-by: Chris Kirby <ckirby@versity.com>
If a set of tests is provided, loop over the entire set the requested number of times. Start and stop any requested tracing across the set boundary. Signed-off-by: Chris Kirby <ckirby@versity.com>
It's possible for a srch compaction to collapse down to nothing if given evenly paired create/delete entries. In this case, we were emitting an empty block. This could cause problems for search_sorted_file(), which assumes that every block it sees has a valid first and last entry. Fix this by keeping a temp entry and only emitting it if it differs from the next entry in the block. Be sure to flush out a straggling temp entry if we have one when we're done with the last block of the merge. Signed-off-by: Chris Kirby <ckirby@versity.com>
The "server error emptying freed" error was causing a fence-and-reclaim test failure. In this case, the error was -ENOLINK, which we should ignore for messaging purposes. Signed-off-by: Chris Kirby <ckirby@versity.com>
chriskirby1
force-pushed
the
clk/srch-fixes
branch
from
88379e2 to
9b27e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.