Skip to content

Enhance CMake configuration for test suite options#4

Merged
ajeetsinghyadav merged 14 commits intomainfrom
VNE_LOGGING_CONFIG_NAME_CHANGE
Feb 14, 2026
Merged

Enhance CMake configuration for test suite options#4
ajeetsinghyadav merged 14 commits intomainfrom
VNE_LOGGING_CONFIG_NAME_CHANGE

Conversation

@ajeetsinghyadav
Copy link
Member

@ajeetsinghyadav ajeetsinghyadav commented Feb 14, 2026

  • Added a new option, VNE_LOGGING_TESTS, to control the inclusion of the vnelogging test suite, allowing it to be turned off when used as a submodule.
  • Updated the test inclusion condition to check both BUILD_TESTS and VNE_LOGGING_TESTS, ensuring tests are only enabled when both options are set to ON.

@ajeetsinghyadav
Enhance CMake configuration for test suite options
c98092e 
- Added a new option, VNE_LOGGING_TESTS, to control the inclusion of the vnelogging test suite, allowing it to be turned off when used as a submodule.
- Updated the test inclusion condition to check both BUILD_TESTS and VNE_LOGGING_TESTS, ensuring tests are only enabled when both options are set to ON.
Copilot AI review requested due to automatic review settings February 14, 2026 15:24
@ajeetsinghyadav ajeetsinghyadav self-assigned this Feb 14, 2026
@ajeetsinghyadav ajeetsinghyadav added the enhancement New feature or request label Feb 14, 2026
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the CMake configuration to provide fine-grained control over test suite inclusion when vnelogging is used as a submodule. It introduces a new CMake option VNE_LOGGING_TESTS that works alongside the existing BUILD_TESTS option, allowing parent projects to disable vnelogging tests while keeping their own tests enabled.

Changes:

  • Added VNE_LOGGING_TESTS option (default: ON) to control vnelogging test suite inclusion
  • Updated test inclusion logic to require both BUILD_TESTS and VNE_LOGGING_TESTS to be ON
  • Updated comment to clarify the dual-condition requirement for test building

@ajeetsinghyadav
Enhance CMake configuration for build presets
e6bb0cf 
- Introduced options for DEV and CI build presets in CMake, allowing for more flexible build configurations.
- Updated CI workflow to utilize the new VNE_LOGGING_CI option, ensuring tests are enabled in CI builds while examples are disabled.
- Added logic to apply build settings based on the selected preset, improving clarity and control over the build process.
@ajeetsinghyadav
Updated vne math to use vne dep use
daff950
Copilot AI review requested due to automatic review settings February 14, 2026 16:35
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ajeetsinghyadav
Update CMakeLists.txt
1a823fb 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 16:38
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@ajeetsinghyadav
Update CMakeLists.txt
f8aad9f 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 16:40
@ajeetsinghyadav
Update CMakeLists.txt
aadd26e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

ajeetsinghyadav and others added 2 commits February 14, 2026 11:44
@ajeetsinghyadav
chore: update cmake/vnecmake submodule to current origin/main (fix mi…
6f7264a 
…ssing ref)
@ajeetsinghyadav
Update CMakeLists.txt
84c26c5 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 16:50
@ajeetsinghyadav
Update CMakeLists.txt
2a161fc 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@ajeetsinghyadav
Update CMakeLists.txt
9c41a45 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 16:53
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@ajeetsinghyadav
Update CMakeLists.txt
228551d 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 17:15
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ajeetsinghyadav
Update CMakeLists.txt
cebd399 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 17:17
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@ajeetsinghyadav
Update CMakeLists.txt
73bbf40 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 17:32
@ajeetsinghyadav
Update CMakeLists.txt
cad427e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ajeetsinghyadav ajeetsinghyadav merged commit d3c7441 into main Feb 14, 2026
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sonulohani sonulohani Awaiting requested review from sonulohani

Assignees

@ajeetsinghyadav ajeetsinghyadav

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ajeetsinghyadav