Remove PCRE dependency and replace with standard C++ regex#20
Merged
mkottakota1 merged 2 commits intomainfrom Feb 11, 2026
Merged
Remove PCRE dependency and replace with standard C++ regex#20mkottakota1 merged 2 commits intomainfrom
mkottakota1 merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
@DMickens I have tested the changes locally. I am going to work on fixing the pipelines by creating a new user story. |
We have removed the dependency on PCRE, removing the documentation related to pcre
91c7379 to
3314e84
Compare
Collaborator
Author
|
@DMickens Hi Danny, Kindly review this MR and let me know your comments |
lazern
approved these changes
Feb 11, 2026
Collaborator
lazern
left a comment
There was a problem hiding this comment.
The changes to replace PCRE with standard std::regex looks good.
While PCRE generally offers better performance compared to std::regex, that advantage is irrelevant in this case as i can see the regex is only used once during SQL translation in setup(), rather than being applied repeatedly for per-row parsing.
Approving the MR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This change removes the dependency on the Perl Compatible Regular Expression (PCRE) libraries (pcre-devel, pcre-cpp) and replaces PCRE-based usage with the standard C++ std::regex implementation.
Why this change:
Eliminates the need for external PCRE packages, simplifying build and deployment on modern Linux distributions (e.g., Rocky Linux, Amazon Linux).
Improves portability and reduces friction when building ODBC Loader in minimal or containerized environments.
Aligns with customer requests to remove PCRE as a build-time dependency.
What changed:
Replaced PCRE-based regular expression handling with std::regex.
Updated build logic to remove PCRE include paths and linker flags.
No functional change in regex behavior for supported patterns.
Impact / Compatibility:
No change to public APIs or loader behavior.
No runtime dependency on PCRE libraries.
Build output remains functionally equivalent.
Testing:
Built ODBC Loader without pcre-devel and pcre-cpp installed.
Verified loader functionality with existing test cases.