Open
Conversation
Added documentation
replaced Switch case to if else
Fixed extra param.
Conflicts: src/android/MarketoPlugin.java
Added Security Patch and Config Notification Patch for android
Added iOS code and a bug fix for Android
ios Bug Fix
ios Bug Fixed
Security Patch + Configure Notification
Associate Lead function name change
Bug fix for iOS
Using Android's ActivityLifecyclecallbacks in Android SDK
MOB-2795 Migrate from GCM to FCM for Phonegap's Android SDK
Since PLATFORM.IOS has not been defined, I am commenting out the installation steps defined in lines 34 and 35.
…y(PLATFORM.IOS) This is currently causing error or breaks when CI/CD is used to add the plugin at build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that IOS_DIR was undefined and this causes issues when adding the marketo plugin for the iOS platform. The instructions for firebase are missing and thus both the documentation and the code need to update accordingly.