Skip to content

fix: corrected handling when events in different order #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epike wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: corrected handling when events in different order #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 80 additions & 43 deletions src/touchscreen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ using namespace v8;
using namespace node;

NAN_METHOD(Async);
void AsyncWork(uv_work_t* req);
void AsyncAfter(uv_work_t* req);
void AsyncWork(uv_work_t *req);
void AsyncAfter(uv_work_t *req);

struct TouchInfo {
struct TouchInfo
{
int fileDescriptor;
Nan::Callback *callback;

Expand All @@ -25,32 +26,38 @@ struct TouchInfo {
int x;
int y;
int pressure;

int touch;
int currentTouchValue;
bool stop;
};

NAN_METHOD(Async) {
NAN_METHOD(Async)
{
// Nan::HandleScope scope;

if (info[0]->IsUndefined()) {
if (info[0]->IsUndefined())
{
return Nan::ThrowError("No parameters specified");
}

if (!info[0]->IsString()) {
if (!info[0]->IsString())
{
return Nan::ThrowError("First parameter should be a string");
}

if (info[1]->IsUndefined()) {
if (info[1]->IsUndefined())
{
return Nan::ThrowError("No callback function specified");
}

if (!info[1]->IsFunction()) {
if (!info[1]->IsFunction())
{
return Nan::ThrowError("Second argument should be a function");
}

Nan::Utf8String *path = new Nan::Utf8String(info[0]);

TouchInfo* touchInfo = new TouchInfo();
TouchInfo *touchInfo = new TouchInfo();
touchInfo->fileDescriptor = open(**path, O_RDONLY);
touchInfo->callback = new Nan::Callback(info[1].As<Function>());
touchInfo->error = false;
Expand All @@ -66,82 +73,112 @@ NAN_METHOD(Async) {
info.GetReturnValue().SetUndefined();
}

void AsyncWork(uv_work_t* req) {
TouchInfo* touchInfo = static_cast<TouchInfo*>(req->data);
void AsyncWork(uv_work_t *req)
{
TouchInfo *touchInfo = static_cast<TouchInfo *>(req->data);

touchInfo->read = read(touchInfo->fileDescriptor, touchInfo->inputEvents, sizeof(struct input_event) * 64);

if (touchInfo->read < (int) sizeof(struct input_event)) {
if (touchInfo->read < (int)sizeof(struct input_event))
{
touchInfo->error = true;
touchInfo->errorMessage = "Read problem";
}
}

void AsyncAfter(uv_work_t* req) {
void AsyncAfter(uv_work_t *req)
{
Nan::HandleScope scope;

TouchInfo* touchInfo = static_cast<TouchInfo*>(req->data);
TouchInfo *touchInfo = static_cast<TouchInfo *>(req->data);

if (touchInfo->error) {
if (touchInfo->error)
{
Local<Value> err = Exception::Error(Nan::New<String>(touchInfo->errorMessage.c_str()).ToLocalChecked());

const unsigned argc = 1;
Local<Value> argv[argc] = { err };
Local<Value> argv[argc] = {err};

TryCatch try_catch;

touchInfo->callback->Call(Nan::GetCurrentContext()->Global(), argc, argv);

if (try_catch.HasCaught()) {
if (try_catch.HasCaught())
{
FatalException(try_catch);
}
} else {
for (unsigned i = 0; i < touchInfo->read / sizeof(struct input_event); i++) {
if (touchInfo->inputEvents[i].type == EV_SYN) {
} else if (touchInfo->inputEvents[i].type == EV_ABS && (touchInfo->inputEvents[i].code == ABS_Y)) {
}
else
{
for (unsigned i = 0; i < touchInfo->read / sizeof(struct input_event); i++)
{
if (touchInfo->inputEvents[i].type == EV_SYN)
{
continue;
}
else if (touchInfo->inputEvents[i].type == EV_ABS && (touchInfo->inputEvents[i].code == ABS_Y))
{
touchInfo->x = touchInfo->inputEvents[i].value;
} else if (touchInfo->inputEvents[i].type == EV_ABS && (touchInfo->inputEvents[i].code == ABS_X)) {
}
else if (touchInfo->inputEvents[i].type == EV_ABS && (touchInfo->inputEvents[i].code == ABS_X))
{
touchInfo->y = touchInfo->inputEvents[i].value;
} else if (touchInfo->inputEvents[i].type == EV_ABS && (touchInfo->inputEvents[i].code == ABS_PRESSURE)) {
}
else if (touchInfo->inputEvents[i].type == EV_ABS && (touchInfo->inputEvents[i].code == ABS_PRESSURE))
{
touchInfo->pressure = touchInfo->inputEvents[i].value;
} else if (touchInfo->inputEvents[i].type == EV_KEY && (touchInfo->inputEvents[i].code == BTN_TOUCH)) {
Local<Object> touch = Nan::New<Object>();
touch->Set(Nan::New<String>("x").ToLocalChecked(), Nan::New<Number>(touchInfo->x));
touch->Set(Nan::New<String>("y").ToLocalChecked(), Nan::New<Number>(touchInfo->y));
touch->Set(Nan::New<String>("pressure").ToLocalChecked(), Nan::New<Number>(touchInfo->pressure));
touch->Set(Nan::New<String>("touch").ToLocalChecked(), Nan::New<Number>(touchInfo->inputEvents[i].value));
touch->Set(Nan::New<String>("stop").ToLocalChecked(), Nan::New<Boolean>(touchInfo->stop));
}
else if (touchInfo->inputEvents[i].type == EV_KEY && (touchInfo->inputEvents[i].code == BTN_TOUCH))
{
touchInfo->currentTouchValue = touchInfo->inputEvents[i].value;
}
}

const unsigned argc = 2;
Local<Value> argv[argc] = { Nan::Null(), touch };
// just to detect real touched, but we block here the continous data flow of pressure and coordinates
if (touchInfo->currentTouchValue != touchInfo->touch)
{
touchInfo->touch = touchInfo->currentTouchValue;
Local<Object> touch = Nan::New<Object>();
touch->Set(Nan::New<String>("x").ToLocalChecked(), Nan::New<Number>(touchInfo->x));
touch->Set(Nan::New<String>("y").ToLocalChecked(), Nan::New<Number>(touchInfo->y));
touch->Set(Nan::New<String>("pressure").ToLocalChecked(), Nan::New<Number>(touchInfo->pressure));
touch->Set(Nan::New<String>("touch").ToLocalChecked(), Nan::New<Number>(touchInfo->touch));
touch->Set(Nan::New<String>("stop").ToLocalChecked(), Nan::New<Boolean>(touchInfo->stop));

TryCatch try_catch;
const unsigned argc = 2;
Local<Value> argv[argc] = {Nan::Null(), touch};

touchInfo->callback->Call(Nan::GetCurrentContext()->Global(), argc, argv);
touchInfo->stop = touch->Get(Nan::New<String>("stop").ToLocalChecked())->BooleanValue();
TryCatch try_catch;

if (try_catch.HasCaught()) {
FatalException(try_catch);
}
touchInfo->callback->Call(Nan::GetCurrentContext()->Global(), argc, argv);
touchInfo->stop = touch->Get(Nan::New<String>("stop").ToLocalChecked())->BooleanValue();

if (try_catch.HasCaught())
{
FatalException(try_catch);
}
}

if (touchInfo->stop) {
if (touchInfo->stop)
{
delete touchInfo->callback;
delete touchInfo;
delete req;
} else {
}
else
{
int status = uv_queue_work(uv_default_loop(), req, AsyncWork, (uv_after_work_cb)AsyncAfter);
assert(status == 0);
}
}
}

void InitAll(Handle<Object> exports, Handle<Object> module) {
void InitAll(Handle<Object> exports, Handle<Object> module)
{
Nan::HandleScope scope;

module->Set(Nan::New("exports").ToLocalChecked(),
Nan::New<FunctionTemplate>(Async)->GetFunction());
Nan::New<FunctionTemplate>(Async)->GetFunction());
}

NODE_MODULE(ts, InitAll)