add docstrings (numPy style) to methods in utils#35
Open
lena-kuhn wants to merge 1 commit intovgrabovets:masterfrom
lena-kuhn:feat/add_docstrings
Open
add docstrings (numPy style) to methods in utils#35lena-kuhn wants to merge 1 commit intovgrabovets:masterfrom lena-kuhn:feat/add_docstrings
lena-kuhn wants to merge 1 commit intovgrabovets:masterfrom
lena-kuhn:feat/add_docstrings
Conversation
vgrabovets
reviewed
Aug 19, 2019
Owner
There was a problem hiding this comment.
Great! Thank you for your work.
Could you, please, also fix really small issues with code style: https://travis-ci.org/vgrabovets/multi_rake/builds/573329575
Here is how to run checks locally: https://github.com/vgrabovets/multi_rake#development
If you want to continue, I would be really grateful. Just ping me when you're done and I will merge it and release to pypi.
|
|
||
| Parameters | ||
| ---------- | ||
| text : utf8Bytes |
|
|
||
|
|
||
| def separate_words(text): | ||
| """Seperate text to tokens by whitespace and dimiss numeric tokens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started equipping this great implementation of rake algorithm with docstrings according to the numpydoc guide. If you see fit, I can extend writing docstrings to algorithm.py and stopwords.py