Put commas between chunks #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
added a commit
to 9999years/timeago
that referenced
this pull request
Aug 28, 2025
These methods make it possible to customize the whitespace in the output. This enables additional punctuation (like the commas proposed in vi#11) and abbreviated output formats (often desired in command-line applications, like `1h 30m 15s`).
9999years
added a commit
to 9999years/timeago
that referenced
this pull request
Aug 28, 2025
These methods make it possible to customize the whitespace in the output. This enables additional punctuation (like the commas proposed in vi#11) and abbreviated output formats (often desired in command-line applications, like `1h 30m 15s`). The default implementations encode the previous behavior; therefore, no change is made to the observed behavior of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it's any good.
Although it looks more right (and less verbose and easier than
ands), a list oftimeagos would look less nice. Maybe better to keep punctuation away?/* Actually this pull request is created just to test Travis setup */