Fix Asana section mapping to correctly parse 'Project:Section' format #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memberships_for_task method was incorrectly looking for a section whose name matched the entire "Project:Section" string (e.g., "Pets:Bucky"), but Asana section names are just the section part (e.g., "Bucky"). This fix: - Parses the "Project:Section" format to extract project and section names - Looks up the project by project name first - Then finds the section by section name within that specific project - Handles edge cases: blank project, missing section, colons in section names Fixes #137
Resolved conflict in memberships_for_task by keeping the fix that correctly parses 'Project:Section' format instead of the old buggy code that looked for a section name matching the entire string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memberships_for_task method was incorrectly looking for a section
whose name matched the entire "Project:Section" string (e.g., "Pets:Bucky"),
but Asana section names are just the section part (e.g., "Bucky").
This fix:
Fixes #137