Make recursive inotify directory watchers fully asynchronous#252
Merged
Make recursive inotify directory watchers fully asynchronous#252
Conversation
Reimplements the inotify based watcher so that iterating over sub directories is done in an I/O worker thread instead of blocking the calling thread.
dirEntries always calls stat to determine if an entry is a directory, which makes iterating over large directory hierarchies very slow.
l-kramer
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids blocking the calling thread for possibly long periods of time when iterating over large directory hierarchies to create watches for each directory.