Conversation
amansethi00
reviewed
Apr 6, 2021
amansethi00
left a comment
amansethi00
left a comment
There was a problem hiding this comment.
Amazing work 🤯,I like your approach of putting components in array and loop over it when clicked in the view,I didn't find any such major changes in code,just added some small suggestions
| border: "1px solid rgba(31, 41, 55)", | ||
| navHover: "#131314", | ||
| highlightBcg: "#26272b", | ||
| codeBcg: "#222328", |
There was a problem hiding this comment.
use variables instead hard coding,here repetitions of numerical value is seen
Owner
Author
There was a problem hiding this comment.
Its not exactly hard coded. Its the theme that I am providing to the context and they are reused everywhere like backgroundColor: theme.highlightBcg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARS.css Component Library
Dev Preview: https://pars.netlify.app/
Open for PR review @Team-Asynchronous @vaishnavme @amansethi00
Things to do: