Skip to content

fix bug when set text programmatically that show wrong mask #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
halakaluf wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix bug when set text programmatically that show wrong mask #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83fc4fa
fix bug when set text programmatically that show wrong mask
halakaluf Feb 13, 2018
5c52679
refactoring raw method to include all characters from mask not only #
halakaluf Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions Pod/Classes/VMaskTextField.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,21 @@ - (instancetype)initWithFrame:(CGRect)frame

-(void) setTextWithMask:(NSString *) text{
NSAssert(_mask!=nil, @"Mask is nil.");
int currentStartRange = 0;
for (int i = 0; i < text.length; i++) {
currentStartRange = i;
if (self.text.length == _mask.length) {
break;
}
[self shouldChangeCharactersInRange:NSMakeRange(self.text.length, 0) replacementString:[NSString stringWithFormat:@"%c",[text characterAtIndex:i]]];

//fix bug reported on https://github.com/viniciusmo/VMaskTextField/issues/20
NSString *strToGetCharacterInMask = [_mask substringWithRange:NSMakeRange(0, i)];
Copy link

@CavalcanteLeo CavalcanteLeo Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crashes here

NSString *strWithCharacterInMask = [strToGetCharacterInMask stringByReplacingOccurrencesOfString:@"#" withString:@""];
int totalOfCharacterInMask = [strWithCharacterInMask length];
int totalOfRangeToAdd = [[[_mask substringWithRange:NSMakeRange(0, i+totalOfCharacterInMask)] stringByReplacingOccurrencesOfString:@"#" withString:@""] length];
currentStartRange += totalOfRangeToAdd;

[self shouldChangeCharactersInRange:NSMakeRange(currentStartRange, 0) replacementString:[NSString stringWithFormat:@"%c",[text characterAtIndex:i]]];
}
}

Expand All @@ -47,15 +57,8 @@ - (BOOL)shouldChangeCharactersInRange:(NSRange)range replacementString:(NSString
}

-(NSString *)raw{
NSMutableString *string = [NSMutableString new];
for (int i=0; i<self.text.length; i++) {
unichar charMask = [self.mask characterAtIndex:i];
unichar charText = [self.text characterAtIndex:i];
if (charMask == '#') {
[string appendFormat:@"%c", charText];
}
}
return string;
NSCharacterSet *charsToRemove = [NSCharacterSet characterSetWithCharactersInString:self.mask];
return [[self.text componentsSeparatedByCharactersInSet: charsToRemove] componentsJoinedByString: @""];
}

-(double) rawToDouble{
Expand Down