Skip to content

Add missing CLI endpoints#113

Open
JoshSEdwards wants to merge 2 commits intovinyldns:mainfrom
JoshSEdwards:implement-missing-api-endpoints
Open

Add missing CLI endpoints#113
JoshSEdwards wants to merge 2 commits intovinyldns:mainfrom
JoshSEdwards:implement-missing-api-endpoints

Conversation

@JoshSEdwards
Copy link
Contributor

@JoshSEdwards JoshSEdwards commented Jan 5, 2026

Summary

  • add CLI commands for health/status/metrics endpoints (ping/health/color/metrics/status/status-update)
  • add CLI commands for zone extras (details, backend IDs, deleted changes, failed changes, ACL rule add/delete)
  • add CLI commands for record set extras (update, count, history, failed changes)
  • add CLI commands for ownership transfer (request/approve/reject/cancel)
  • add CLI commands for group/user extras (group-change, group-valid-domains, user, user-lock, user-unlock)
  • add CLI commands for batch review (approve/reject/cancel)
  • extend Bats suite with coverage for new commands and error-path checks

Dependency

Manual Testing

Note: go.mod currently points at the latest released go-vinyldns. This PR depends on new client methods that are still in review in go-vinyldns PR #102, so local testing needs a temporary replace to your local go-vinyldns checkout. Do not commit this change; it is only for local testing until go-vinyldns is released.

  • go mod edit -replace github.com/vinyldns/go-vinyldns=../go-vinyldns
  • gmake test (starts the local VinylDNS API and runs Bats)
  • optional spot checks:
    • bin/vinyldns ping
    • bin/vinyldns health
    • bin/vinyldns status --output=json
    • bin/vinyldns zone-details --zone-name ok. --output=json
    • bin/vinyldns record-set-history --zone-name ok. --record-set-fqdn some-cname.ok. --record-set-type CNAME --output=json
    • bin/vinyldns record-set-ownership-request --zone-name ok. --record-set-id <id> --requested-owner-group-id <groupId>
    • bin/vinyldns batch-change-approve --batch-change-id <id> (admin/manual review enabled)

VDNS-253

@snyk-io
Copy link

snyk-io bot commented Jan 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@JoshSEdwards JoshSEdwards changed the title Add missing CLI endpoints for VDNS-253 Add missing CLI endpoints Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments