Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
go.modreplaceManual Testing
Note:
go.modcurrently points at the latest released go-vinyldns. This PR depends on new client methods that are still in review in go-vinyldns PR #102, so local testing needs a temporaryreplaceto your local go-vinyldns checkout. Do not commit this change; it is only for local testing until go-vinyldns is released.go mod edit -replace github.com/vinyldns/go-vinyldns=../go-vinyldnsgmake test(starts the local VinylDNS API and runs Bats)bin/vinyldns pingbin/vinyldns healthbin/vinyldns status --output=jsonbin/vinyldns zone-details --zone-name ok. --output=jsonbin/vinyldns record-set-history --zone-name ok. --record-set-fqdn some-cname.ok. --record-set-type CNAME --output=jsonbin/vinyldns record-set-ownership-request --zone-name ok. --record-set-id <id> --requested-owner-group-id <groupId>bin/vinyldns batch-change-approve --batch-change-id <id>(admin/manual review enabled)VDNS-253