Draft
Conversation
This is in service of addressing issue #84
* create shared func for deleting record sets * it appears it's necessary to sleep for more than 3 seconds
It's possible this is not needed, but it seems as though it is.
The status may be 'Syncing'; let's avoid making assertions on the Status.
It seems we _still_ sometimes encounter a `400: zones-test-group is the admin of a zone. Cannot delete`. Bumping the sleep duration to 6 seconds is an attempt to work around that.
This is an attempt to address this failure, which seems to indicate that 10 seconds is not long enough to wait: https://travis-ci.org/github/vinyldns/vinyldns-cli/jobs/746760191#L336-L363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR to POC PR #92 in more detail.