Add new group change route and fix attributes#90
Open
Aravindh-Raju wants to merge 3 commits intovinyldns:masterfrom
Open
Add new group change route and fix attributes#90Aravindh-Raju wants to merge 3 commits intovinyldns:masterfrom
Aravindh-Raju wants to merge 3 commits intovinyldns:masterfrom
Conversation
nspadaccino
reviewed
Dec 12, 2023
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.vinyldns.java; |
Member
There was a problem hiding this comment.
Could we just import io.vinyldns.java.model.membership here as in the other GroupRequest classes, instead of the whole io.vinyldns.java package?
nspadaccino
reviewed
Dec 12, 2023
Member
nspadaccino
left a comment
nspadaccino
left a comment
There was a problem hiding this comment.
One comment, otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextIdandstartFromfrom string to int as per the change here for recordset change to payload and response data.startFromandnextIdfrom string to int as per the change here for group change to payload and response data.