Only pass strings to setProperty as the value argument on IE9 requires DOMString#58
Open
philipooo wants to merge 1 commit intovisionmedia:masterfrom
Open
Only pass strings to setProperty as the value argument on IE9 requires DOMString#58philipooo wants to merge 1 commit intovisionmedia:masterfrom
philipooo wants to merge 1 commit intovisionmedia:masterfrom
Conversation
Author
|
Any plans to merge this? |
|
Mostly they'll never merge other's commitment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error occured on IE9 when trying to execute:
So I searched for the problem and found out that IE9 doesn't like it when passing a DOMNumber (opacity 0) into the style.setProperty function.
http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleDeclaration-setProperty