-
-
Notifications
You must be signed in to change notification settings - Fork 297
fix: filter embedding generation by project name #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ject source code retrieval
Summary of ChangesHello @wjcgithub, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the embedding generation process would incorrectly attempt to process functions from unrelated projects, leading to errors. The core change introduces project-specific filtering into the database query for embeddings, ensuring that only relevant code entities are considered during indexing. This improves the robustness and accuracy of the embedding generation for individual repositories. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug where embedding generation was attempted for functions outside the current project. The filtering by project_name in the Cypher query is a direct and effective solution. I've added one suggestion to slightly optimize the database query by removing an unnecessary ORDER BY clause, which could improve performance.
Fixes cross-repository embedding generation by filtering functions from the current project only. Previously, indexing a repository would attempt to generate embeddings for all functions in the database, including those from other projects, leading to file not found errors.