Skip to content

Conversation

@wjcgithub
Copy link

Fixes cross-repository embedding generation by filtering functions from the current project only. Previously, indexing a repository would attempt to generate embeddings for all functions in the database, including those from other projects, leading to file not found errors.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wjcgithub, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the embedding generation process would incorrectly attempt to process functions from unrelated projects, leading to errors. The core change introduces project-specific filtering into the database query for embeddings, ensuring that only relevant code entities are considered during indexing. This improves the robustness and accuracy of the embedding generation for individual repositories.

Highlights

  • Embedding Generation Filtering: The Cypher query used for generating semantic embeddings has been updated to filter functions and methods based on the project name. This ensures that only entities belonging to the current project are considered, preventing cross-repository issues.
  • Parameterization of Embedding Query: The _generate_semantic_embeddings method now passes the current project's name as a parameter to the embedding query. This dynamic filtering prevents the system from attempting to generate embeddings for functions from other projects.
  • Dependency Update: The graph-code dependency has been updated from version 0.0.36 to 0.0.40 in the uv.lock file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug where embedding generation was attempted for functions outside the current project. The filtering by project_name in the Cypher query is a direct and effective solution. I've added one suggestion to slightly optimize the database query by removing an unnecessary ORDER BY clause, which could improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant