Skip to content

Fixes NoMethodError for empty routing tables #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
L33tH4x0r wants to merge 2 commits into
base: 4.4.6
Choose a base branch
from
+3 −3
Open

Fixes NoMethodError for empty routing tables #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff1191
VST-98338 Fix NoMethodError when routing table handlers map is empty
L33tH4x0r Mar 13, 2026
d3a836d
VST-98338 Bump version
L33tH4x0r Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ruby/neo4j/driver/internal/cluster/routing_table_handler_impl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def fresh_cluster_composition_fetched(composition_lookup_result)
@log.debug("Fetched cluster composition for database '#{@database_name.description}'. #{composition_lookup_result.cluster_composition}")
@routing_table.update(composition_lookup_result.cluster_composition)
@routing_table_registry.remove_aged
addresses_to_retain = @routing_table_registry.all_servers.map(&:unicast_stream).reduce(&:+)
addresses_to_retain = @routing_table_registry.all_servers.map(&:unicast_stream).reduce(Set.new, :+)

composition_lookup_result.resolved_initial_routers&.then do |addresses|
addresses_to_retain << addresses
Expand Down
2 changes: 1 addition & 1 deletion ruby/neo4j/driver/internal/cluster/routing_table_registry_impl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def ensure_routing_table(context)
def all_servers
# obviously we just had a snapshot of all servers in all routing tables
# after we read it, the set could already be changed.
@routing_table_handlers.values.map(&:servers).reduce(&:+)
@routing_table_handlers.values.map(&:servers).reduce(Set.new, :+)
end

def remove(database_name)
Expand Down
2 changes: 1 addition & 1 deletion ruby/neo4j/driver/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Neo4j
module Driver
VERSION = '4.4.5'
VERSION = '4.4.6'
end
end