test(optimizer): add CJS __esModule interop tests#21519
Merged
sapphi-red merged 6 commits intomainfrom Jan 29, 2026
Merged
Conversation
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port tests from Vite pull request 16437
test: port CJS Jan 29, 2026
__esModule interop tests from #16437
Co-authored-by: FinalAshen <819712530@qq.com>
__esModule interop tests from #16437__esModule interop tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports test coverage from #16437 for CJS modules with
__esModuleflag to ensure dev/build interop consistency with Rollup.Changes
dep-cjs-with-es-module-flag- CommonJS module with__esModule: trueoptimize-depsplaygroundoptimizeDeps.includefor prebundling coverageContext
CJS modules compiled from ESM (via TypeScript, Babel, etc.) set
__esModule: trueto signal default export behavior. Vite's interop handling must match Rollup's to avoid runtime discrepancies between dev and prod.Credits: @XiSenao
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
workers.cloudflare.com/opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/vite/vite/node_modules/.pnpm/vitest@4.0.18_@types+node@22.19.7/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/vite/vite/node_modules/.pnpm/vitest@4.0.18_@types+node@22.19.7/node_modules/vitest/dist/workers/forks.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.