fix(commonjs): ignoreDynamicRequires should default to false#4015
Merged
patak-dev merged 1 commit intovitejs:mainfrom Jun 29, 2021
Merged
fix(commonjs): ignoreDynamicRequires should default to false#4015patak-dev merged 1 commit intovitejs:mainfrom
ignoreDynamicRequires should default to false#4015patak-dev merged 1 commit intovitejs:mainfrom
Conversation
patak-dev
approved these changes
Jun 29, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #3353 (comment)
Comparing to the behavior before v2.3.1, the new default now throws a runtime error in the following case:
require(/* a dynamic expression */), wheredynamicRequireTargetsis specified, but the expression in therequirecall cannot be resolved via the targets.Comparing to the behavior since v2.3.1, the new default fixes the following use case:
typeof require ==== 'function'It is used in many legacy UMD bundles for CommonJS environment detection.
Fixes #3426
Fixes #3997
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).