Tests for the watched paths store

[vittorius]

• Added tests for "watcher" methods in PathStore
• Extracted WatchedSet type into a separate module (tests TBA)

PR train:

• Tests for the watched paths store #16 (this one)
• Notify Zed of error in LSP server #19
• Tests for WatchedSet #22
• Tests for PathWatcher #23

[vittorius]

Fixed, wasn't working properly

[vittorius]

Turned out to be redundant

[vittorius]

Renamed from Store

[bloodfeast]

just a couple notes, overall good job!

[bloodfeast]

1.fs::read_to_string is synchronous and will block the async runtime's thread.

• You could use tokio::fs::read_to_string and make the function async

async fn process_and_sync(client: &dyn Client, event: &Event) -> Result<()> {
  let path = event.paths.first()
      .ok_or_else(|| anyhow!("event missing path"))?;
  
  let body = tokio::fs::read_to_string(path).await
      .with_context(|| format!("failed to read {}", path.display()))?;
  
  let data = LocalFileData::new(path.clone(), body)?;
  client.sync_file(data).await
}

2. adding the path here would be useful context

.with_context(|| format!("Could not read modified file: {}", path.display()))?;

[bloodfeast]

You could filter here before the async overhead

        let EventKind::Modify(ModifyKind::Data(_)) = event.kind else {
            return Box::pin(async {}) as Pin<Box<dyn Future<Output = ()> + Send>>;
        };

[vittorius]

Decided to keep this logic in the process_event function