Conversation
Owner
vittorius
commented
Jan 19, 2026
vittorius
commented
- Tests for the ZedConfigFilePath type
- Tests for the Backend type
- Other minor changes
ChronosWS
suggested changes
Jan 19, 2026
|
|
||
| async fn init_lsp_backend_default() -> Result<Backend> { | ||
| init_lsp_backend(Some(json!({ | ||
| "github_token": "gho_my-shiny-token", |
There was a problem hiding this comment.
Should these keys be constants? They seem common and expected by the initialization code?
Owner
Author
There was a problem hiding this comment.
They are the field names of the Config type. So I had no need to extract them into constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.