Open
Conversation
I would like to get rid of the phun on my README.md [1]. pretty-data is currently not minifying very much in regards to XML optimization. Thus I would like to suggest, you could switch to my library minify-xml. It is also based on simple regular expression replacements, thus it is fits very well to your library. I also took your "between tags" and "comment" regular expressions and adapted them. This change is compatible to existing usages of your API. If preserveComments is set, it will be forwarded to my library with the same behaviour. This is just a suggestion, but my library is optimizing many more things in regards to XML such as removing unnecessary whitespace in attributes, removing unused namespaces, collapsing empty elements. It also features a better CDATA handling, as the way you did it could easily fail when to be optimized things are part of CDATA. [1] https://github.com/kristian/minify-xml#readme
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to get rid of the phun on my README.md [1]. pretty-data is
currently not minifying very much in regards to XML optimization. Thus
I would like to suggest, you could switch to my library minify-xml. It
is also based on simple regular expression replacements, thus it is fits
very well to your library. I also took your "between tags" and "comment"
regular expressions and adapted them.
This change is compatible to existing usages of your API. If
preserveComments is set, it will be forwarded to my library with the
same behaviour.
This is just a suggestion, but my library is optimizing many more things
in regards to XML such as removing unnecessary whitespace in attributes,
removing unused namespaces, collapsing empty elements. It also features
a better CDATA handling, as the way you did it could easily fail when
to be optimized things are part of CDATA.
[1] https://github.com/kristian/minify-xml#readme