Support distributed kv cache orchestration#583
Merged
Conversation
varungup90
reviewed
Jan 21, 2025
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
9d497e0 to
787c672
Compare
varungup90
approved these changes
Jan 21, 2025
| func needsUpdateDeployment(deployment *appsv1.Deployment, found *appsv1.Deployment) bool { | ||
| imageChanged := false | ||
| for i, container := range found.Spec.Template.Spec.Containers { | ||
| if len(deployment.Spec.Template.Spec.Containers) > i { |
Collaborator
There was a problem hiding this comment.
we can also have a scenario where number of containers are not same. Second, better to have a second loop to match by container name rather than depending on the container index (removes the assumption part). This can be a future TODO.
Collaborator
Author
There was a problem hiding this comment.
These are great suggestions. Sure, I create a new issue to track your proposed improvements #587.
Collaborator
Author
|
I will merge this issue now and finish Varun's suggestion in later PRs. |
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Add kv cache api or distributed kv orchestration * Update the kvcache api spec * Add KV Cache controller initial implementation * Support affinity Node & Pod settings * Adjust manifest to orchestration folders * fix the ci check * Address review feedback * Update code based on rebase refactor * Fix the linter issue --------- Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
* Add kv cache api or distributed kv orchestration * Update the kvcache api spec * Add KV Cache controller initial implementation * Support affinity Node & Pod settings * Adjust manifest to orchestration folders * fix the ci check * Address review feedback * Update code based on rebase refactor * Fix the linter issue --------- Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Support distributed kv cache orchestration #570
KVCache, it will create the etcd, cache dataplane and necessary service for vLLM engine to communicate withExample
it will create following resources
cache deployment
individual pod
services
Related Issues
Resolves: #570
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.