Skip to content

feat: support list span & trace detail in apmplus#377

Open
danielqsj wants to merge 1 commit intovolcengine:mainfrom
danielqsj:feat/apmplus-trace
Open

feat: support list span & trace detail in apmplus#377
danielqsj wants to merge 1 commit intovolcengine:mainfrom
danielqsj:feat/apmplus-trace

Conversation

@danielqsj
Copy link
Contributor

Support list span & trace detail in apmplus.
Added two new tools:

  • apmplus_server_get_trace_detail
  • apmplus_server_list_span

@cuericlee
Copy link
Collaborator

@danielqsj peer review is needed

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds APMPlus trace/span querying capabilities to the mcp_server_apmplus MCP server, along with related SDK/config updates and documentation/version bumps.

Changes:

  • Add two new MCP tools: apmplus_server_get_trace_detail and apmplus_server_list_span.
  • Refactor auth/config handling to support region + volcengine SDK client configuration and bump dependencies.
  • Update README docs/versioning and add a local test.py harness.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
server/mcp_server_apmplus/src/mcp_server_apmplus/server.py Adds the new tools, moves CLI main() here, and updates auth/config initialization.
server/mcp_server_apmplus/src/mcp_server_apmplus/api.py Introduces volcengine SDK client usage for trace detail and span listing; adjusts request host handling.
server/mcp_server_apmplus/src/mcp_server_apmplus/config.py Expands config to include region and pool_concurrency and adds volcengine SDK configuration conversion.
server/mcp_server_apmplus/src/mcp_server_apmplus/model.py Renames request field region_idregion for server APIs.
server/mcp_server_apmplus/src/mcp_server_apmplus/test.py Adds async unittest-based integration-style test harness for the tools.
server/mcp_server_apmplus/src/mcp_server_apmplus/main.py Removed (CLI entrypoint relocation).
server/mcp_server_apmplus/pyproject.toml Bumps version/deps and configures uv git source for volcengine SDK.
server/mcp_server_apmplus/requirements.txt Switches volcengine SDK dependency to a git+ssh reference.
server/mcp_server_apmplus/uv.lock Updates lockfile for new dependencies (mcp bump, black, volcengine SDK via git, etc.).
server/mcp_server_apmplus/README.md Documents new tools and updates version to v0.2.0.
server/mcp_server_apmplus/README_zh.md Documents new tools and updates version to v0.2.0.
server/mcp_server_apmplus/.gitignore Adds a Python-focused ignore file for this package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielqsj danielqsj force-pushed the feat/apmplus-trace branch 2 times, most recently from 5a3e99a to 6561a48 Compare March 9, 2026 11:57
@danielqsj danielqsj force-pushed the feat/apmplus-trace branch from 6561a48 to 1473493 Compare March 9, 2026 13:39
@feng-95
Copy link
Contributor

feng-95 commented Mar 9, 2026

+LGTM

@danielqsj
Copy link
Contributor Author

@cuericlee peer reviewed, pls take a look, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants