feat: support list span & trace detail in apmplus#377
Open
danielqsj wants to merge 1 commit intovolcengine:mainfrom
Open
feat: support list span & trace detail in apmplus#377danielqsj wants to merge 1 commit intovolcengine:mainfrom
danielqsj wants to merge 1 commit intovolcengine:mainfrom
Conversation
Collaborator
|
@danielqsj peer review is needed |
There was a problem hiding this comment.
Pull request overview
Adds APMPlus trace/span querying capabilities to the mcp_server_apmplus MCP server, along with related SDK/config updates and documentation/version bumps.
Changes:
- Add two new MCP tools:
apmplus_server_get_trace_detailandapmplus_server_list_span. - Refactor auth/config handling to support region + volcengine SDK client configuration and bump dependencies.
- Update README docs/versioning and add a local
test.pyharness.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| server/mcp_server_apmplus/src/mcp_server_apmplus/server.py | Adds the new tools, moves CLI main() here, and updates auth/config initialization. |
| server/mcp_server_apmplus/src/mcp_server_apmplus/api.py | Introduces volcengine SDK client usage for trace detail and span listing; adjusts request host handling. |
| server/mcp_server_apmplus/src/mcp_server_apmplus/config.py | Expands config to include region and pool_concurrency and adds volcengine SDK configuration conversion. |
| server/mcp_server_apmplus/src/mcp_server_apmplus/model.py | Renames request field region_id → region for server APIs. |
| server/mcp_server_apmplus/src/mcp_server_apmplus/test.py | Adds async unittest-based integration-style test harness for the tools. |
| server/mcp_server_apmplus/src/mcp_server_apmplus/main.py | Removed (CLI entrypoint relocation). |
| server/mcp_server_apmplus/pyproject.toml | Bumps version/deps and configures uv git source for volcengine SDK. |
| server/mcp_server_apmplus/requirements.txt | Switches volcengine SDK dependency to a git+ssh reference. |
| server/mcp_server_apmplus/uv.lock | Updates lockfile for new dependencies (mcp bump, black, volcengine SDK via git, etc.). |
| server/mcp_server_apmplus/README.md | Documents new tools and updates version to v0.2.0. |
| server/mcp_server_apmplus/README_zh.md | Documents new tools and updates version to v0.2.0. |
| server/mcp_server_apmplus/.gitignore | Adds a Python-focused ignore file for this package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5a3e99a to
6561a48
Compare
6561a48 to
1473493
Compare
Contributor
|
+LGTM |
Contributor
Author
|
@cuericlee peer reviewed, pls take a look, thanks~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support list span & trace detail in apmplus.
Added two new tools: