[transport] detect and warn about unaligned esc sequences#112
Open
r00t- wants to merge 1 commit intovolkszaehler:masterfrom
Open
[transport] detect and warn about unaligned esc sequences#112r00t- wants to merge 1 commit intovolkszaehler:masterfrom
r00t- wants to merge 1 commit intovolkszaehler:masterfrom
Conversation
50834d7 to
e15b9f7
Compare
Collaborator
Author
|
this could be merged as-is, but it would heavily spam a user's log in case of a desync. |
Collaborator
Author
|
(also the code is rather simplistic and inefficient, there should be better ways to do this.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first step of improvement towards #103 (see also devZer0/libsml-testing#12 )
this at least provides a warning: