Workaround for Holley DTZ541#76
Merged
andig merged 4 commits intovolkszaehler:masterfrom Oct 31, 2019
Merged
Conversation
hacki11
commented
Sep 22, 2019
hacki11
commented
- handling incorrect sml_time object
- support crc-16/kermit algorithm
- handling incorrect sml_time object - support crc-16/kermit algorithm
Author
|
Fixed review findings |
Author
|
If there aren’t any more findings a merge would be nice |
|
Out of curiosity- why the unrelated whitespace change? Does that make anything more consistent? |
Author
|
Seems that was my auto formatting of clion. Perhaps tab replacement with whitespaces and indentation fixes. Can revert that changes if you want. |
|
Please revert unwanted changes and check style- this repo is typically using tabs, you have spaces apparently. Reformatting the entire codebase would be a different issue. |
Author
|
fixed |
andig
reviewed
Oct 30, 2019
| if (sml_buf_get_next_length(buf) != 2) { | ||
| buf->error = 1; | ||
| goto error; | ||
| } |
Author
There was a problem hiding this comment.
Doch, der Block gehört nun in den else Zweig
|
Fixes #75 |
This was referenced Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.